summaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorKenny Ballou <kballou@devnulllabs.io>2018-03-23 16:52:16 -0600
committerKenny Ballou <kballou@devnulllabs.io>2018-03-23 21:21:07 -0600
commitf6c19219c3174963db7ab7934bea5657bac9040f (patch)
tree945e738c977fad4dfa3be15b885aef6504def97b
parent496924e6c2e3904f6224be504d23a9a32ab824ea (diff)
downloadgit-in-reverse-f6c19219c3174963db7ab7934bea5657bac9040f.tar.gz
git-in-reverse-f6c19219c3174963db7ab7934bea5657bac9040f.tar.xz
add commit message examples
-rw-r--r--src/git-in-reverse.tex44
1 files changed, 44 insertions, 0 deletions
diff --git a/src/git-in-reverse.tex b/src/git-in-reverse.tex
index a8e9eb0..14b7db4 100644
--- a/src/git-in-reverse.tex
+++ b/src/git-in-reverse.tex
@@ -11,6 +11,7 @@
\usepackage{color}
\usepackage{tikz}
\usetikzlibrary{trees, shapes.misc, arrows}
+\usepackage{fancyvrb}
\usepackage{pgfkeys}
\usepackage{graphicx}
\usepackage[normalem]{ulem}
@@ -1058,6 +1059,49 @@ Because \texttt{git-log} output \textit{needs} to be beautiful:
\lstinputlisting{code/gitlog}
\end{frame}
+\begin{frame}[fragile]
+ \frametitle{Writing Good Commit Messages}
+ \framesubtitle{Examples}
+\begin{Verbatim}[fontsize=\small]
+i dont think this stuff is needed
+\end{Verbatim}
+\end{frame}
+
+\begin{frame}[fragile]
+ \frametitle{Writing Good Commit Messages}
+ \framesubtitle{Examples}
+\begin{Verbatim}[fontsize=\scriptsize]
+Convert ROM read access enable/disable string parsing to use the
+`kstrtobool` function.
+
+This fixes Bugzilla Bug 111301 -- Sysfs PCI rom file functionality does
+not match documentation.
+
+bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=111301
+
+Reported-by: googlegot@xxxxxxxxx
+Signed-off-by: Kenny Ballou <kballou@xxxxxxxxxxxxxx>
+\end{Verbatim}
+\end{frame}
+
+\begin{frame}[fragile]
+ \frametitle{Writing Good Commit Messages}
+ \framesubtitle{Examples}
+\begin{Verbatim}[fontsize=\scriptsize]
+object.h: update flag allocation comment
+
+Since the "flags" is shared, it's a good idea to keep track of who
+uses what bit. When we need to use more flags in library code, we can
+be sure it won't be re-used for another purpose by some caller.
+
+While at there, fix the location of "5" (should be in a different
+column than "4" two lines down)
+
+Signed-off-by: Nguyễn Thái Ngọc Duy <pclouds@gmail.com>
+Signed-off-by: Junio C Hamano <gitster@pobox.com>
+\end{Verbatim}
+\end{frame}
+
\subsection{git-pull}
\begin{frame}[fragile]
\frametitle{\texttt{git-pull} considered harmful}