aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@osdl.org>2005-10-09 02:30:17 -0700
committerJunio C Hamano <junkio@cox.net>2005-10-28 02:01:42 -0700
commit9106c097ad87577019544f45fda11c4d73986597 (patch)
tree2c5d370f099ef78342624e224f9aa4a8b5c68dcd
parentc1aaa5d9ea4a148a964f8c4d6de8bc65f1dc44fd (diff)
downloadgit-9106c097ad87577019544f45fda11c4d73986597.tar.gz
git-9106c097ad87577019544f45fda11c4d73986597.tar.xz
Create object subdirectories on demand (phase II)
This removes the unoptimization. The previous round does not mind missing fan-out directories, but still makes sure they exist, lest older versions choke on a repository created/packed by it. This round does not play that nicely anymore -- empty fan-out directories are not created by init-db, and will stay removed by prune-packed. The prune command also removes empty fan-out directories. Signed-off-by: Junio C Hamano <junkio@cox.net>
-rwxr-xr-xgit-prune.sh1
-rw-r--r--init-db.c4
-rw-r--r--prune-packed.c3
-rwxr-xr-xt/t0000-basic.sh8
4 files changed, 6 insertions, 10 deletions
diff --git a/git-prune.sh b/git-prune.sh
index 9657dbf27..b28630cac 100755
--- a/git-prune.sh
+++ b/git-prune.sh
@@ -22,6 +22,7 @@ sed -ne '/unreachable /{
}' | {
cd "$GIT_OBJECT_DIRECTORY" || exit
xargs $echo rm -f
+ rmdir 2>/dev/null [0-9a-f][0-9a-f]
}
git-prune-packed $dryrun
diff --git a/init-db.c b/init-db.c
index 2a4aa3c19..ca6fa4d42 100644
--- a/init-db.c
+++ b/init-db.c
@@ -281,10 +281,6 @@ int main(int argc, char **argv)
memcpy(path, sha1_dir, len);
safe_create_dir(sha1_dir);
- for (i = 0; i < 256; i++) {
- sprintf(path+len, "/%02x", i);
- safe_create_dir(path);
- }
strcpy(path+len, "/pack");
safe_create_dir(path);
strcpy(path+len, "/info");
diff --git a/prune-packed.c b/prune-packed.c
index 1e0fc0cd9..16685d1d8 100644
--- a/prune-packed.c
+++ b/prune-packed.c
@@ -27,8 +27,7 @@ static void prune_dir(int i, DIR *dir, char *pathname, int len)
error("unable to unlink %s", pathname);
}
pathname[len] = 0;
- if (!rmdir(pathname))
- mkdir(pathname, 0777);
+ rmdir(pathname);
}
static void prune_packed_objects(void)
diff --git a/t/t0000-basic.sh b/t/t0000-basic.sh
index 5c5f85485..dff7d6916 100755
--- a/t/t0000-basic.sh
+++ b/t/t0000-basic.sh
@@ -28,12 +28,12 @@ test_expect_success \
'.git/objects should be empty after git-init-db in an empty repo.' \
'cmp -s /dev/null should-be-empty'
-# also it should have 258 subdirectories; 256 fan-out anymore, pack, and info.
-# 259 is counting "objects" itself
+# also it should have 2 subdirectories; no fan-out anymore, pack, and info.
+# 3 is counting "objects" itself
find .git/objects -type d -print >full-of-directories
test_expect_success \
- '.git/objects should have 258 subdirectories.' \
- 'test $(wc -l < full-of-directories) = 259'
+ '.git/objects should have 3 subdirectories.' \
+ 'test $(wc -l < full-of-directories) = 3'
################################################################
# Basics of the basics