diff options
| author | Yasushi SHOJI <yashi@atmark-techno.com> | 2006-10-14 21:02:51 +0900 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-10-14 18:22:04 -0700 |
| commit | ced78b3907dd60d8289ad5385ffcfd3339149957 (patch) | |
| tree | 495457faf1f65f0d983ecc20029371f5e5e75f5c | |
| parent | d988b82232bb8f5826a1619fd4dcba1a5a330f27 (diff) | |
| download | git-ced78b3907dd60d8289ad5385ffcfd3339149957.tar.gz git-ced78b3907dd60d8289ad5385ffcfd3339149957.tar.xz | |
clone: the given repository dir should be relative to $PWD
the repository argument for git-clone should be relative to $PWD
instead of the given target directory. The old behavior gave us
surprising success and you need a few minute to know why it worked.
GIT_DIR is already exported so no need to cd into $D. And this makes
$PWD for git-fetch-pack, which is the actual command to take the given
repository dir, the same as git-clone.
Signed-off-by: Yasushi SHOJI <yashi@atmark-techno.com>
Signed-off-by: Junio C Hamano <junkio@cox.net>
| -rwxr-xr-x | git-clone.sh | 2 | ||||
| -rwxr-xr-x | t/t5600-clone-fail-cleanup.sh | 6 |
2 files changed, 7 insertions, 1 deletions
diff --git a/git-clone.sh b/git-clone.sh index 3998c55ce..bf54a1150 100755 --- a/git-clone.sh +++ b/git-clone.sh @@ -312,7 +312,7 @@ yes,yes) fi ;; *) - cd "$D" && case "$upload_pack" in + case "$upload_pack" in '') git-fetch-pack --all -k $quiet "$repo" ;; *) git-fetch-pack --all -k $quiet "$upload_pack" "$repo" ;; esac >"$GIT_DIR/CLONE_HEAD" || { diff --git a/t/t5600-clone-fail-cleanup.sh b/t/t5600-clone-fail-cleanup.sh index 0c6a363be..041be04f5 100755 --- a/t/t5600-clone-fail-cleanup.sh +++ b/t/t5600-clone-fail-cleanup.sh @@ -25,6 +25,12 @@ test_create_repo foo # clone doesn't like it if there is no HEAD. Is that a bug? (cd foo && touch file && git add file && git commit -m 'add file' >/dev/null 2>&1) +# source repository given to git-clone should be relative to the +# current path not to the target dir +test_expect_failure \ + 'clone of non-existent (relative to $PWD) source should fail' \ + 'git-clone ../foo baz' + test_expect_success \ 'clone should work now that source exists' \ 'git-clone foo bar' |