aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDaniel Drake <dsd@gentoo.org>2006-07-24 23:07:23 +0100
committerJunio C Hamano <junkio@cox.net>2006-07-25 14:05:55 -0700
commit143c89b00348759d2768003d57e0f506d281dc61 (patch)
tree7301eaaf2fa1493215a1fea8f762e66e9e2deedd
parent09f5dc406a9e6630af881108af815f6c3fb6d9df (diff)
downloadgit-143c89b00348759d2768003d57e0f506d281dc61.tar.gz
git-143c89b00348759d2768003d57e0f506d281dc61.tar.xz
gitweb: escape tag comments
I have a tag with a comment which includes an & character. Firefox wouldn't display my gitweb summary page due to malformed XML. This solves the problem. Signed-off-by: Daniel Drake <dsd@gentoo.org> Signed-off-by: Junio C Hamano <junkio@cox.net>
-rwxr-xr-xgitweb/gitweb.cgi2
1 files changed, 1 insertions, 1 deletions
diff --git a/gitweb/gitweb.cgi b/gitweb/gitweb.cgi
index 2fd1e5f78..5acd66dd6 100755
--- a/gitweb/gitweb.cgi
+++ b/gitweb/gitweb.cgi
@@ -1138,7 +1138,7 @@ sub git_summary {
"</td>\n" .
"<td>";
if (defined($comment)) {
- print $cgi->a({-class => "list", -href => "$my_uri?" . esc_param("p=$project;a=tag;h=$tag{'id'}")}, $comment);
+ print $cgi->a({-class => "list", -href => "$my_uri?" . esc_param("p=$project;a=tag;h=$tag{'id'}")}, esc_html($comment));
}
print "</td>\n" .
"<td class=\"link\">";