diff options
| author | Kay Sievers <kay.sievers@suse.de> | 2006-01-17 03:50:20 +0100 |
|---|---|---|
| committer | Kay Sievers <kay.sievers@suse.de> | 2006-01-17 03:50:20 +0100 |
| commit | 2c5c008b462fd5d2e32318077aaa3bc4e67c84fd (patch) | |
| tree | c18277c5278f84a0ad3b94cef68cec2f4a28630e | |
| parent | f76ddc20159256a1bc6e3ba81910ae94faaf2fa8 (diff) | |
| download | git-2c5c008b462fd5d2e32318077aaa3bc4e67c84fd.tar.gz git-2c5c008b462fd5d2e32318077aaa3bc4e67c84fd.tar.xz | |
fix: Use of uninitialized value
The subroutine did not check the case where HEAD does not verify.
Patch from Junio C Hamano <junkio@cox.net>
| -rwxr-xr-x | gitweb.cgi | 9 |
1 files changed, 5 insertions, 4 deletions
diff --git a/gitweb.cgi b/gitweb.cgi index 986d7dacd..cb033733b 100755 --- a/gitweb.cgi +++ b/gitweb.cgi @@ -404,12 +404,13 @@ sub git_read_head { if (open my $fd, "-|", "$gitbin/git-rev-parse", "--verify", "HEAD") { my $head = <$fd>; close $fd; - chomp $head; - if ($head =~ m/^[0-9a-fA-F]{40}$/) { - $retval = $head; + if (defined $head && $head =~ /^([0-9a-fA-F]{40})$/) { + $retval = $1; } } - $ENV{'GIT_DIR'} = $oENV; + if (defined $oENV) { + $ENV{'GIT_DIR'} = $oENV; + } return $retval; } |