aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorSergey Vlasov <vsu@altlinux.ru>2005-09-21 20:34:29 +0400
committerJunio C Hamano <junkio@cox.net>2005-09-21 12:32:33 -0700
commit4041483e5a3d2010e038ec686ef1638cde659f0b (patch)
tree03aa935cc5161e014eb48e1741941069f86f7bc1
parent478dbeec9936e4556a9232f1fd908ffe2a96a723 (diff)
downloadgit-4041483e5a3d2010e038ec686ef1638cde659f0b.tar.gz
git-4041483e5a3d2010e038ec686ef1638cde659f0b.tar.xz
[PATCH] fetch.c: Remove call to parse_object() from process()
The call to parse_object() in process() is not actually needed - if the object type is unknown, parse_object() will be called by loop(); if the type is known, the object will be parsed by the appropriate process_*() function. After this change blobs which exist locally are no longer parsed, which gives about 2x CPU usage improvement; the downside is that there will be no warnings for existing corrupted blobs, but detecting such corruption is the job of git-fsck-objects, not the fetch programs. Newly fetched objects are still checked for corruption in http-fetch.c and ssh-fetch.c (local-fetch.c does not seem to do it, but the removed parse_object() call would not be reached for new objects anyway). Signed-off-by: Sergey Vlasov <vsu@altlinux.ru> Signed-off-by: Junio C Hamano <junkio@cox.net>
-rw-r--r--fetch.c1
1 files changed, 0 insertions, 1 deletions
diff --git a/fetch.c b/fetch.c
index b92ca8038..e6fd624c1 100644
--- a/fetch.c
+++ b/fetch.c
@@ -134,7 +134,6 @@ static int process(struct object *obj)
obj->flags |= SEEN;
if (has_sha1_file(obj->sha1)) {
- parse_object(obj->sha1);
/* We already have it, so we should scan it now. */
obj->flags |= TO_SCAN;
} else {