aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGreg Brockman <gdb@MIT.EDU>2010-07-20 00:46:21 -0400
committerJunio C Hamano <gitster@pobox.com>2010-07-25 10:33:47 -0700
commit1b0b962d771fb734cbf273f216b487bb58dec7b9 (patch)
treed64781b85c89766bece6a4811dda57db71cafb82
parent29981380d03ffa63765dbeaea53a7ac9e8d6bc4f (diff)
downloadgit-1b0b962d771fb734cbf273f216b487bb58dec7b9.tar.gz
git-1b0b962d771fb734cbf273f216b487bb58dec7b9.tar.xz
Check size of path buffer before writing into it
This prevents a buffer overrun that could otherwise be triggered by creating a file called '.git' with contents gitdir: (something really long) Signed-off-by: Greg Brockman <gdb@mit.edu> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--setup.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/setup.c b/setup.c
index e3781b656..01e1a6a7c 100644
--- a/setup.c
+++ b/setup.c
@@ -153,6 +153,8 @@ static int is_git_directory(const char *suspect)
char path[PATH_MAX];
size_t len = strlen(suspect);
+ if (PATH_MAX <= len + strlen("/objects"))
+ die("Too long path: %.*s", 60, suspect);
strcpy(path, suspect);
if (getenv(DB_ENVIRONMENT)) {
if (access(getenv(DB_ENVIRONMENT), X_OK))