aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorGerrit Pape <pape@smarden.org>2008-02-11 10:57:40 +0000
committerPaul Mackerras <paulus@samba.org>2008-02-12 10:05:59 +1100
commit48750d6a84a7fc08dcd7cb4533c280c00106f9b6 (patch)
tree2868d5223eaad309f4386ce7490a719f9f0f55a5
parentb9b86007e27d9a06d58feab618a5be1d491ed13e (diff)
downloadgit-48750d6a84a7fc08dcd7cb4533c280c00106f9b6.tar.gz
git-48750d6a84a7fc08dcd7cb4533c280c00106f9b6.tar.xz
[PATCH] gitk: properly deal with tag names containing / (slash)
When creating a tag through gitk, and the tag name includes a slash (or slashes), gitk errors out in a popup window. This patch makes gitk use 'git tag' to create the tag instead of modifying files in refs/tags/, which fixes the issue; if 'git tag' throws an error, gitk pops up with the error message. The problem was reported by Frédéric Brière through http://bugs.debian.org/464104 Signed-off-by: Gerrit Pape <pape@smarden.org> Signed-off-by: Paul Mackerras <paulus@samba.org>
-rwxr-xr-xgitk6
1 files changed, 1 insertions, 5 deletions
diff --git a/gitk b/gitk
index dab9df067..80544bfc5 100755
--- a/gitk
+++ b/gitk
@@ -6149,11 +6149,7 @@ proc domktag {} {
return
}
if {[catch {
- set dir [gitdir]
- set fname [file join $dir "refs/tags" $tag]
- set f [open $fname w]
- puts $f $id
- close $f
+ exec git tag $tag $id
} err]} {
error_popup "[mc "Error creating tag:"] $err"
return