aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJakub Narebski <jnareb@gmail.com>2010-01-24 19:05:23 +0100
committerJunio C Hamano <gitster@pobox.com>2010-01-24 17:48:08 -0800
commitb2c2e4c22c6a4fe151f02380d247cf3d9a9d5d1e (patch)
treeae0a1347bfeb92c2e627dd6ecb3d41a821147c71
parent026680f881e751311674d97d0f6ed87f06a92bfb (diff)
downloadgit-b2c2e4c22c6a4fe151f02380d247cf3d9a9d5d1e.tar.gz
git-b2c2e4c22c6a4fe151f02380d247cf3d9a9d5d1e.tar.xz
gitweb.js: Workaround for IE8 bugv1.7.0-rc0
In Internet Explorer 8 (IE8) the 'blame_incremental' view, which uses JavaScript to generate blame info using AJAX, sometimes hang at the beginning (at 0%) of blaming, e.g. for larger files with long history like git's own gitweb/gitweb.perl. The error shown by JavaScript console is "Unspecified error" at char:2 of the following line in gitweb/gitweb.js: if (xhr.readyState === 3 && xhr.status !== 200) { Debugging it using IE8 JScript debuger shown that the error occurs when trying to access xhr.status (xhr is XMLHttpRequest object). Watch for xhr object shows 'Unspecified error.' as "value" of xhr.status, and trying to access xhr.status from console throws error. This bug is some intermittent bug, depending on XMLHttpRequest timing, as it doesn't occur in all cases. It is probably caused by the fact that handleResponse is called from timer (pollTimer), to work around the fact that some browsers call onreadystatechange handler only once for each state change, and not like required for 'blame_incremental' as soon as new data is available from server. It looks like xhr object is not properly initialized; still it is a bug to throw an error when accessing xhr.status (and not use 'null' or 'undefined' as value). Work around this bug in IE8 by using try-catch block when accessing xhr.status. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--gitweb/gitweb.js7
1 files changed, 6 insertions, 1 deletions
diff --git a/gitweb/gitweb.js b/gitweb/gitweb.js
index 2a25b7cc4..9c66928c4 100644
--- a/gitweb/gitweb.js
+++ b/gitweb/gitweb.js
@@ -779,7 +779,12 @@ function handleResponse() {
}
// the server returned error
- if (xhr.readyState === 3 && xhr.status !== 200) {
+ // try ... catch block is to work around bug in IE8
+ try {
+ if (xhr.readyState === 3 && xhr.status !== 200) {
+ return;
+ }
+ } catch (e) {
return;
}
if (xhr.readyState === 4 && xhr.status !== 200) {