diff options
author | Jeff King <peff@peff.net> | 2013-01-26 17:40:38 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2013-01-26 19:25:38 -0800 |
commit | 131b8fcbfbea0acee8d78a8f9b2b3fee4285aee5 (patch) | |
tree | 04bd5afd5104fe96d78528ea1705585a4e616bb6 | |
parent | 7e2010537e96d0a1144520222f20ba1dc3d61441 (diff) | |
download | git-131b8fcbfbea0acee8d78a8f9b2b3fee4285aee5.tar.gz git-131b8fcbfbea0acee8d78a8f9b2b3fee4285aee5.tar.xz |
fetch: run gc --auto after fetching
We generally try to run "gc --auto" after any commands that
might introduce a large number of new objects. An obvious
place to do so is after running "fetch", which may introduce
new loose objects or packs (depending on the size of the
fetch).
While an active developer repository will probably
eventually trigger a "gc --auto" on another action (e.g.,
git-rebase), there are two good reasons why it is nicer to
do it at fetch time:
1. Read-only repositories which track an upstream (e.g., a
continuous integration server which fetches and builds,
but never makes new commits) will accrue loose objects
and small packs, but never coalesce them into a more
efficient larger pack.
2. Fetching is often already perceived to be slow to the
user, since they have to wait on the network. It's much
more pleasant to include a potentially slow auto-gc as
part of the already-long network fetch than in the
middle of productive work with git-rebase or similar.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r-- | builtin/fetch.c | 5 |
1 files changed, 5 insertions, 0 deletions
diff --git a/builtin/fetch.c b/builtin/fetch.c index f483352fe..cffa3f736 100644 --- a/builtin/fetch.c +++ b/builtin/fetch.c @@ -960,6 +960,9 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) struct string_list list = STRING_LIST_INIT_NODUP; struct remote *remote; int result = 0; + static const char *argv_gc_auto[] = { + "gc", "--auto", NULL, + }; packet_trace_identity("fetch"); @@ -1027,5 +1030,7 @@ int cmd_fetch(int argc, const char **argv, const char *prefix) list.strdup_strings = 1; string_list_clear(&list, 0); + run_command_v_opt(argv_gc_auto, RUN_GIT_CMD); + return result; } |