diff options
| author | Johannes Sixt <j6t@kdbg.org> | 2013-06-06 08:34:41 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-06-06 10:22:52 -0700 |
| commit | 04422c74c88e2d5d78210bad65e95b223a18fd8e (patch) | |
| tree | 27baf3180dfd8c2306f602b446102e582376f181 | |
| parent | e828908aa97ce0441b0c00a640b314c041fbd9e2 (diff) | |
| download | git-04422c74c88e2d5d78210bad65e95b223a18fd8e.tar.gz git-04422c74c88e2d5d78210bad65e95b223a18fd8e.tar.xz | |
t0005: skip signal death exit code test on Windows
The test case depends on that test-sigchain can commit suicide by a
call to raise(SIGTERM) in a way that run-command.c::wait_or_whine()
can detect as death through a signal. There are no POSIX signals on
Windows, and a sufficiently close emulation is not available in the
Microsoft C runtime (and probably not even possible).
The particular deficiency is that when a signal is raise()d whose
SIG_DFL action will cause process death (SIGTERM in this case), the
implementation of raise() in msvcrt just calls exit(3).
We could check for exit code 3 in addition to 143, but that would
miss the point of the test entirely. Hence, just skip it on Windows.
Signed-off-by: Johannes Sixt <j6t@kdbg.org>
Acked-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rwxr-xr-x | t/t0005-signals.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t0005-signals.sh b/t/t0005-signals.sh index ad9e6047f..981437b3a 100755 --- a/t/t0005-signals.sh +++ b/t/t0005-signals.sh @@ -20,7 +20,7 @@ test_expect_success 'sigchain works' ' test_cmp expect actual ' -test_expect_success 'signals are propagated using shell convention' ' +test_expect_success !MINGW 'signals are propagated using shell convention' ' # we use exec here to avoid any sub-shell interpretation # of the exit code git config alias.sigterm "!exec test-sigchain" && |