aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorChristian Couder <chriscool@tuxfamily.org>2008-07-06 06:10:04 +0200
committerJunio C Hamano <gitster@pobox.com>2008-07-05 23:30:38 -0700
commit3ecb171d2b9aca7b09bf112594977d00925893b4 (patch)
tree3f2a7e8c89fe10e2e2cd7cfdd6e59ff20a49d42a
parent9b373229506c9f563b2e2f053c3f1d932789fbfd (diff)
downloadgit-3ecb171d2b9aca7b09bf112594977d00925893b4.tar.gz
git-3ecb171d2b9aca7b09bf112594977d00925893b4.tar.xz
Fix "config_error_nonbool" used with value instead of key
The function "config_error_nonbool", that is defined in "config.c", is used to report an error when a config key in the config file should have a corresponding value but it hasn't. So the parameter to this function should be the key and not the value, because the value is undefined. And it could crash if the value is used. Signed-off-by: Christian Couder <chriscool@tuxfamily.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--builtin-tag.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-tag.c b/builtin-tag.c
index e675206de..3c97c696a 100644
--- a/builtin-tag.c
+++ b/builtin-tag.c
@@ -260,7 +260,7 @@ static int git_tag_config(const char *var, const char *value, void *cb)
{
if (!strcmp(var, "user.signingkey")) {
if (!value)
- return config_error_nonbool(value);
+ return config_error_nonbool(var);
set_signingkey(value);
return 0;
}