diff options
author | Elia Pinto <gitter.spiros@gmail.com> | 2014-04-30 09:23:02 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-04-30 11:08:07 -0700 |
commit | 7c0c51baa4855c76a71820fb279c2ca1580d374b (patch) | |
tree | 23d7a5d0cdefde5240d2ebf9e7e285892b0ff773 | |
parent | 20cb28baf9d03c779f590baa475610788bc6eabf (diff) | |
download | git-7c0c51baa4855c76a71820fb279c2ca1580d374b.tar.gz git-7c0c51baa4855c76a71820fb279c2ca1580d374b.tar.xz |
t4038-diff-combined.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
sed -i 's@`\(.*\)`@$(\1)@g' ${_f}
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Matthieu Moy <Matthieu.Moy@imag.fr>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-x | t/t4038-diff-combined.sh | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/t/t4038-diff-combined.sh b/t/t4038-diff-combined.sh index 1019d7b35..41913c3aa 100755 --- a/t/t4038-diff-combined.sh +++ b/t/t4038-diff-combined.sh @@ -94,7 +94,7 @@ test_expect_success 'setup for --cc --raw' ' blob=$(echo file | git hash-object --stdin -w) && base_tree=$(echo "100644 blob $blob file" | git mktree) && trees= && - for i in `test_seq 1 40` + for i in $(test_seq 1 40) do blob=$(echo file$i | git hash-object --stdin -w) && trees="$trees$(echo "100644 blob $blob file" | git mktree)$LF" |