aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorRamkumar Ramachandra <artagnon@gmail.com>2013-03-31 18:40:42 -0700
committerJunio C Hamano <gitster@pobox.com>2013-03-31 21:30:27 -0700
commita47eab03f613fa55b9e690d5354e95bc165dceee (patch)
tree3a73ed82b67fc7e08c327514d4653af4e8daba3d
parent9b39703920b2d64985abcc1348b169d8fa658c24 (diff)
downloadgit-a47eab03f613fa55b9e690d5354e95bc165dceee.tar.gz
git-a47eab03f613fa55b9e690d5354e95bc165dceee.tar.xz
send-email: use the three-arg form of open in recipients_cmd
Perlcritic does not want to see the trailing pipe in the two-args form of open(), i.e. open my $fh, "$cmd \Q$file\E |"; If $cmd were a single-token command name, it would make a lot more sense to use four-or-more-args form "open FILEHANDLE,MODE,CMD,ARGS" to avoid shell from expanding metacharacters in $file, but we do expect multi-word string in $to_cmd and $cc_cmd to be expanded by the shell, so we cannot rewrite it to open my $fh, "-|", $cmd, $file; for extra safety. At least, by using this in the three-arg form: open my $fh, "-|", "$cmd \Q$file\E"; we can silence Perlcritic, even though we do not gain much safety by doing so. Signed-off-by: Ramkumar Ramachandra <artagnon@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xgit-send-email.perl2
1 files changed, 1 insertions, 1 deletions
diff --git a/git-send-email.perl b/git-send-email.perl
index fd8bfff3b..70cad15ec 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -1440,7 +1440,7 @@ sub recipients_cmd {
my $sanitized_sender = sanitize_address($sender);
my @addresses = ();
- open my $fh, "$cmd \Q$file\E |"
+ open my $fh, "-|", "$cmd \Q$file\E"
or die "($prefix) Could not execute '$cmd'";
while (my $address = <$fh>) {
$address =~ s/^\s*//g;