diff options
| author | Junio C Hamano <gitster@pobox.com> | 2008-08-27 16:39:46 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-08-27 16:39:46 -0700 |
| commit | 5a1e8707a6d9c7016a59d9987c1bc72ffe1252c8 (patch) | |
| tree | f2f8e30270d8231bd7591295e4ce2e9ecf7d0453 | |
| parent | bb0d283989ec8853ffd72dfb26ff557ffa7781e4 (diff) | |
| parent | 4b480c6716a7d8e20e7e510827ea81e7939f335a (diff) | |
| download | git-5a1e8707a6d9c7016a59d9987c1bc72ffe1252c8.tar.gz git-5a1e8707a6d9c7016a59d9987c1bc72ffe1252c8.tar.xz | |
Merge branch 'np/verify-pack'
* np/verify-pack:
discard revindex data when pack list changes
| -rw-r--r-- | builtin-verify-pack.c | 3 | ||||
| -rw-r--r-- | pack-revindex.c | 12 | ||||
| -rw-r--r-- | pack-revindex.h | 1 | ||||
| -rw-r--r-- | sha1_file.c | 1 | ||||
| -rwxr-xr-x | t/t5300-pack-object.sh | 6 |
5 files changed, 22 insertions, 1 deletions
diff --git a/builtin-verify-pack.c b/builtin-verify-pack.c index f4ac59569..25a29f11a 100644 --- a/builtin-verify-pack.c +++ b/builtin-verify-pack.c @@ -1,7 +1,7 @@ #include "builtin.h" #include "cache.h" #include "pack.h" - +#include "pack-revindex.h" #define MAX_CHAIN 50 @@ -129,6 +129,7 @@ int cmd_verify_pack(int argc, const char **argv, const char *prefix) else { if (verify_one_pack(argv[1], verbose)) err = 1; + discard_revindex(); nothing_done = 0; } argc--; argv++; diff --git a/pack-revindex.c b/pack-revindex.c index cd300bdff..6096b6224 100644 --- a/pack-revindex.c +++ b/pack-revindex.c @@ -142,3 +142,15 @@ struct revindex_entry *find_pack_revindex(struct packed_git *p, off_t ofs) } while (lo < hi); die("internal error: pack revindex corrupt"); } + +void discard_revindex(void) +{ + if (pack_revindex_hashsz) { + int i; + for (i = 0; i < pack_revindex_hashsz; i++) + if (pack_revindex[i].revindex) + free(pack_revindex[i].revindex); + free(pack_revindex); + pack_revindex_hashsz = 0; + } +} diff --git a/pack-revindex.h b/pack-revindex.h index 36a514a6c..8d5027ad9 100644 --- a/pack-revindex.h +++ b/pack-revindex.h @@ -7,5 +7,6 @@ struct revindex_entry { }; struct revindex_entry *find_pack_revindex(struct packed_git *p, off_t ofs); +void discard_revindex(void); #endif diff --git a/sha1_file.c b/sha1_file.c index 2aff59b90..9ee1ed16a 100644 --- a/sha1_file.c +++ b/sha1_file.c @@ -990,6 +990,7 @@ void prepare_packed_git(void) void reprepare_packed_git(void) { + discard_revindex(); prepare_packed_git_run_once = 0; prepare_packed_git(); } diff --git a/t/t5300-pack-object.sh b/t/t5300-pack-object.sh index 645583f9d..83abe5f25 100755 --- a/t/t5300-pack-object.sh +++ b/t/t5300-pack-object.sh @@ -187,6 +187,12 @@ test_expect_success \ test-3-${packname_3}.idx' test_expect_success \ + 'verify pack -v' \ + 'git verify-pack -v test-1-${packname_1}.idx \ + test-2-${packname_2}.idx \ + test-3-${packname_3}.idx' + +test_expect_success \ 'verify-pack catches mismatched .idx and .pack files' \ 'cat test-1-${packname_1}.idx >test-3.idx && cat test-2-${packname_2}.pack >test-3.pack && |