aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorÆvar Arnfjörð Bjarmason <avarab@gmail.com>2010-09-30 13:43:02 +0000
committerJunio C Hamano <gitster@pobox.com>2010-09-30 12:20:33 -0700
commitff483897317b5379e189d6bd782270dd08c09966 (patch)
tree500c5a88d51d420e0e6572fab8a1d8e7c0bac10d
parent0d290a46346f465a735bf50244d033e2257b0326 (diff)
downloadgit-ff483897317b5379e189d6bd782270dd08c09966.tar.gz
git-ff483897317b5379e189d6bd782270dd08c09966.tar.xz
send-email: sanitize_address use $foo, not "$foo"
There's no reason to explicitly stringify a variable in Perl unless it's an overloaded object and you want to call overload::StrVal, otherwise it's just creating a new scalar redundantly. Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.comReviewed-by: Avery Pennarun <apenwarr@gmail.com> Reviewed-by: Jeff King <peff@peff.net> > Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rwxr-xr-xgit-send-email.perl2
1 files changed, 1 insertions, 1 deletions
diff --git a/git-send-email.perl b/git-send-email.perl
index 1218bbe72..1bf090a88 100755
--- a/git-send-email.perl
+++ b/git-send-email.perl
@@ -864,7 +864,7 @@ sub sanitize_address {
my ($recipient_name, $recipient_addr) = ($recipient =~ /^(.*?)\s*(<.*)/);
if (not $recipient_name) {
- return "$recipient";
+ return $recipient;
}
# if recipient_name is already quoted, do nothing