diff options
| author | Johannes Schindelin <Johannes.Schindelin@gmx.de> | 2008-02-14 23:26:12 +0000 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-02-15 23:21:57 -0800 |
| commit | 7fea9c551436a98edf4ab6840de981f99b7db687 (patch) | |
| tree | 47a357968bae65ca31f3cfec223c6c192b19c825 | |
| parent | 1bbeb4c6905b18446485413d98f4b75e56a6830c (diff) | |
| download | git-7fea9c551436a98edf4ab6840de981f99b7db687.tar.gz git-7fea9c551436a98edf4ab6840de981f99b7db687.tar.xz | |
http-push: avoid a needless goto
There was a goto, and while it is not half as harmful as some people
believe, it was unnecessary here. So remove it for readability.
Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
| -rw-r--r-- | http-push.c | 5 |
1 files changed, 1 insertions, 4 deletions
diff --git a/http-push.c b/http-push.c index 14ef652ca..f9b77d602 100644 --- a/http-push.c +++ b/http-push.c @@ -2413,12 +2413,9 @@ int main(int argc, char **argv) } while (request_queue_head && !aborted); /* Update the remote branch if all went well */ - if (aborted || !update_remote(ref->new_sha1, ref_lock)) { + if (aborted || !update_remote(ref->new_sha1, ref_lock)) rc = 1; - goto unlock; - } - unlock: if (!rc) fprintf(stderr, " done\n"); unlock_remote(ref_lock); |