diff options
| author | David Barr <davidbarr@google.com> | 2012-06-01 00:41:29 +1000 |
|---|---|---|
| committer | Jonathan Nieder <jrnieder@gmail.com> | 2012-07-05 23:26:53 -0500 |
| commit | c68038effed2f1031848330cca46e85fc79e3ab2 (patch) | |
| tree | 84ed7942c2c44a92b661b88e4a04066142abe1d2 | |
| parent | 6a0b4438afc22551533dccc221bdf802ee4ed5ee (diff) | |
| download | git-c68038effed2f1031848330cca46e85fc79e3ab2.tar.gz git-c68038effed2f1031848330cca46e85fc79e3ab2.tar.xz | |
vcs-svn: suppress a signed/unsigned comparison warning
The preceding code checks that view->max_off is nonnegative and
(off + width) fits in an off_t, so this code is already safe.
Signed-off-by: David Barr <davidbarr@google.com>
Signed-off-by: Jonathan Nieder <jrnieder@gmail.com>
| -rw-r--r-- | vcs-svn/sliding_window.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/vcs-svn/sliding_window.c b/vcs-svn/sliding_window.c index ec2707c9c..f11d49099 100644 --- a/vcs-svn/sliding_window.c +++ b/vcs-svn/sliding_window.c @@ -54,7 +54,7 @@ int move_window(struct sliding_view *view, off_t off, size_t width) return -1; if (off < view->off || off + width < view->off + view->width) return error("invalid delta: window slides left"); - if (view->max_off >= 0 && view->max_off < off + width) + if (view->max_off >= 0 && view->max_off < off + (off_t) width) return error("delta preimage ends early"); file_offset = view->off + view->buf.len; |