aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@g5.osdl.org>2005-07-06 09:56:16 -0700
committerLinus Torvalds <torvalds@g5.osdl.org>2005-07-06 09:56:16 -0700
commitbce6286670c6735d0ca2fdf582047e0388dfcd84 (patch)
tree67b236ad312d3f1fb972f506e6239a47e0a5d775
parent7e21c29b56f80e8fd24613207b4e0116659ad5f8 (diff)
downloadgit-bce6286670c6735d0ca2fdf582047e0388dfcd84.tar.gz
git-bce6286670c6735d0ca2fdf582047e0388dfcd84.tar.xz
Remove insane overlapping bit ranges from epoch.c
..and move the DUPCHECK to rev-list.c since both the merge-order and the upcoming topo-sort get confused by dups.
-rw-r--r--epoch.c10
-rw-r--r--epoch.h12
-rw-r--r--rev-list.c6
3 files changed, 13 insertions, 15 deletions
diff --git a/epoch.c b/epoch.c
index abfd594bb..7888f1da4 100644
--- a/epoch.c
+++ b/epoch.c
@@ -582,14 +582,8 @@ int sort_list_in_merge_order(struct commit_list *list, emitter_func emitter)
int action = CONTINUE;
struct commit_list *reversed = NULL;
- for (; list; list = list->next) {
- struct commit *next = list->item;
-
- if (!(next->object.flags & DUPCHECK)) {
- next->object.flags |= DUPCHECK;
- commit_list_insert(list->item, &reversed);
- }
- }
+ for (; list; list = list->next)
+ commit_list_insert(list->item, &reversed);
if (!reversed)
return ret;
diff --git a/epoch.h b/epoch.h
index 0c1385a5d..7493d5a24 100644
--- a/epoch.h
+++ b/epoch.h
@@ -10,12 +10,12 @@ typedef int (*emitter_func) (struct commit *);
int sort_list_in_merge_order(struct commit_list *list, emitter_func emitter);
-#define UNINTERESTING (1u<<2)
-#define BOUNDARY (1u<<3)
-#define VISITED (1u<<4)
-#define DISCONTINUITY (1u<<5)
-#define DUPCHECK (1u<<6)
-#define LAST_EPOCH_FLAG (1u<<6)
+/* Low bits are used by rev-list */
+#define UNINTERESTING (1u<<10)
+#define BOUNDARY (1u<<11)
+#define VISITED (1u<<12)
+#define DISCONTINUITY (1u<<13)
+#define LAST_EPOCH_FLAG (1u<<14)
#endif /* EPOCH_H */
diff --git a/rev-list.c b/rev-list.c
index c20fec804..e4d167c00 100644
--- a/rev-list.c
+++ b/rev-list.c
@@ -8,7 +8,8 @@
#define SEEN (1u << 0)
#define INTERESTING (1u << 1)
#define COUNTED (1u << 2)
-#define SHOWN (LAST_EPOCH_FLAG << 2)
+#define SHOWN (1u << 3)
+#define DUPCHECK (1u << 4)
static const char rev_list_usage[] =
"usage: git-rev-list [OPTION] commit-id <commit-id>\n"
@@ -485,6 +486,9 @@ int main(int argc, char **argv)
commit = get_commit_reference(arg, flags);
if (!commit)
continue;
+ if (commit->object.flags & DUPCHECK)
+ continue;
+ commit->object.flags |= DUPCHECK;
insert(commit, &list);
}