aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorLinus Torvalds <torvalds@linux-foundation.org>2009-07-08 19:31:49 -0700
committerJunio C Hamano <gitster@pobox.com>2009-07-09 01:11:30 -0700
commitcaa6b7825aaddb8a97a5b793ca61df0c1ec9b76b (patch)
tree1fa18bd1a39279e5e4f5889bb97aae89957cd544
parentdba2e2037f40685bffc87d3e7114a02c5bda1eff (diff)
downloadgit-caa6b7825aaddb8a97a5b793ca61df0c1ec9b76b.tar.gz
git-caa6b7825aaddb8a97a5b793ca61df0c1ec9b76b.tar.xz
Avoid doing extra 'lstat()'s for d_type if we have an up-to-date cache entry
On filesystems without d_type, we can look at the cache entry first. Doing an lstat() can be expensive. Reported by Dmitry Potapov for Cygwin. Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
-rw-r--r--dir.c14
1 files changed, 9 insertions, 5 deletions
diff --git a/dir.c b/dir.c
index b0671f59c..8a9e7d813 100644
--- a/dir.c
+++ b/dir.c
@@ -16,7 +16,7 @@ struct path_simplify {
static int read_directory_recursive(struct dir_struct *dir, const char *path, int len,
int check_only, const struct path_simplify *simplify);
-static int get_dtype(struct dirent *de, const char *path);
+static int get_dtype(struct dirent *de, const char *path, int len);
static int common_prefix(const char **pathspec)
{
@@ -326,7 +326,7 @@ static int excluded_1(const char *pathname,
if (x->flags & EXC_FLAG_MUSTBEDIR) {
if (*dtype == DT_UNKNOWN)
- *dtype = get_dtype(NULL, pathname);
+ *dtype = get_dtype(NULL, pathname, pathlen);
if (*dtype != DT_DIR)
continue;
}
@@ -566,14 +566,18 @@ static int in_pathspec(const char *path, int len, const struct path_simplify *si
return 0;
}
-static int get_dtype(struct dirent *de, const char *path)
+static int get_dtype(struct dirent *de, const char *path, int len)
{
int dtype = de ? DTYPE(de) : DT_UNKNOWN;
+ struct cache_entry *ce;
struct stat st;
if (dtype != DT_UNKNOWN)
return dtype;
- if (lstat(path, &st))
+ ce = cache_name_exists(path, len, 0);
+ if (ce && ce_uptodate(ce))
+ st.st_mode = ce->ce_mode;
+ else if (lstat(path, &st))
return dtype;
if (S_ISREG(st.st_mode))
return DT_REG;
@@ -633,7 +637,7 @@ static int read_directory_recursive(struct dir_struct *dir, const char *base, in
continue;
if (dtype == DT_UNKNOWN)
- dtype = get_dtype(de, path);
+ dtype = get_dtype(de, path, len);
/*
* Do we want to see just the ignored files?