aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2010-12-09 10:36:10 -0800
committerJunio C Hamano <gitster@pobox.com>2010-12-09 10:36:10 -0800
commitae0a37cd6bc05b5ab511d0d1a541dc57d52753e6 (patch)
tree283e01c4e52e198664413234c87b2993796b3e25
parentd3334d9c444a22847e7add0f60c2e4a7243c151e (diff)
parent8837d33595b78dc4a52038856bc9a5c3f4b2ff50 (diff)
downloadgit-ae0a37cd6bc05b5ab511d0d1a541dc57d52753e6.tar.gz
git-ae0a37cd6bc05b5ab511d0d1a541dc57d52753e6.tar.xz
Merge branch 'cm/diff-check-at-eol' into maint
* cm/diff-check-at-eol: diff --check: correct line numbers of new blank lines at EOF
-rw-r--r--diff.c2
-rwxr-xr-xt/t4019-diff-wserror.sh9
2 files changed, 10 insertions, 1 deletions
diff --git a/diff.c b/diff.c
index b829c0335..c8a7ceea0 100644
--- a/diff.c
+++ b/diff.c
@@ -2158,7 +2158,7 @@ static void builtin_checkdiff(const char *name_a, const char *name_b,
ecbdata.ws_rule = data.ws_rule;
check_blank_at_eof(&mf1, &mf2, &ecbdata);
- blank_at_eof = ecbdata.blank_at_eof_in_preimage;
+ blank_at_eof = ecbdata.blank_at_eof_in_postimage;
if (blank_at_eof) {
static char *err;
diff --git a/t/t4019-diff-wserror.sh b/t/t4019-diff-wserror.sh
index f6d1f1eba..87df0aeb5 100755
--- a/t/t4019-diff-wserror.sh
+++ b/t/t4019-diff-wserror.sh
@@ -178,6 +178,15 @@ test_expect_success 'trailing empty lines (2)' '
'
+test_expect_success 'checkdiff shows correct line number for trailing blank lines' '
+
+ printf "a\nb\n" > G &&
+ git add G &&
+ printf "x\nx\nx\na\nb\nc\n\n" > G &&
+ [ "$(git diff --check -- G)" = "G:7: new blank line at EOF." ]
+
+'
+
test_expect_success 'do not color trailing cr in context' '
git config --unset core.whitespace
rm -f .gitattributes &&