aboutsummaryrefslogtreecommitdiff
path: root/bisect.h
diff options
context:
space:
mode:
authorTaylor Blau <me@ttaylorr.com>2017-10-02 09:10:34 -0700
committerJunio C Hamano <gitster@pobox.com>2017-10-05 10:41:57 +0900
commitbea4dbeafda3ddc4404f2e94dce0b66a4105399a (patch)
tree6efc5ff1eb48fffef29c26cdf7d166af51292826 /bisect.h
parent4010f1d1b782eb7585e0e0abcefa794bd5ff29a0 (diff)
downloadgit-bea4dbeafda3ddc4404f2e94dce0b66a4105399a.tar.gz
git-bea4dbeafda3ddc4404f2e94dce0b66a4105399a.tar.xz
ref-filter.c: pass empty-string as NULL to atom parsers
Peff points out that different atom parsers handle the empty "sub-argument" list differently. An example of this is the format "%(refname:)". Since callers often use `string_list_split` (which splits the empty string with any delimiter as a 1-ary string_list containing the empty string), this makes handling empty sub-argument strings non-ergonomic. Let's fix this by declaring that atom parser implementations must not care about distinguishing between the empty string "%(refname:)" and no sub-arguments "%(refname)". Current code aborts, either with "unrecognised arg" (e.g. "refname:") or "does not take args" (e.g. "body:") as an error message. Signed-off-by: Taylor Blau <me@ttaylorr.com> Reviewed-by: Jeff King <peff@peff.net> Reviewed-by: Jonathan Nieder <jrnieder@gmail.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'bisect.h')
0 files changed, 0 insertions, 0 deletions