diff options
author | Junio C Hamano <gitster@pobox.com> | 2008-08-04 00:52:37 -0700 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2008-08-04 23:31:23 -0700 |
commit | 725b06050a083474e240a2436121e0a80bb9f175 (patch) | |
tree | 3831874f7cce9b6307bcf3816525f66973878eba /builtin-add.c | |
parent | 806d13b1ccdbdde4bbdfb96902791c4b7ed125f6 (diff) | |
download | git-725b06050a083474e240a2436121e0a80bb9f175.tar.gz git-725b06050a083474e240a2436121e0a80bb9f175.tar.xz |
add: refuse to add working tree items beyond symlinks
This is the same fix for the issue of adding "sym/path" when "sym" is a
symblic link that points at a directory "dir" with "path" in it.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-add.c')
-rw-r--r-- | builtin-add.c | 12 |
1 files changed, 11 insertions, 1 deletions
diff --git a/builtin-add.c b/builtin-add.c index fc3f96eae..81b64d7b9 100644 --- a/builtin-add.c +++ b/builtin-add.c @@ -153,6 +153,16 @@ static const char **validate_pathspec(int argc, const char **argv, const char *p { const char **pathspec = get_pathspec(prefix, argv); + if (pathspec) { + const char **p; + for (p = pathspec; *p; p++) { + if (has_symlink_leading_path(strlen(*p), *p)) { + int len = prefix ? strlen(prefix) : 0; + die("'%s' is beyond a symbolic link", *p + len); + } + } + } + return pathspec; } @@ -278,7 +288,7 @@ int cmd_add(int argc, const char **argv, const char *prefix) fprintf(stderr, "Maybe you wanted to say 'git add .'?\n"); return 0; } - pathspec = get_pathspec(prefix, argv); + pathspec = validate_pathspec(argc, argv, prefix); /* * If we are adding new files, we need to scan the working |