diff options
| author | Thomas Rast <trast@student.ethz.ch> | 2009-06-27 17:58:47 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2009-06-27 11:14:53 -0700 |
| commit | 0721c314a5c8fddc877140ab5a333c42c62f780d (patch) | |
| tree | 3fbea50f91636df092ac245284e811a32738842c /builtin-archive.c | |
| parent | d824cbba02a4061400a0e382f9bd241fbbff34f0 (diff) | |
| download | git-0721c314a5c8fddc877140ab5a333c42c62f780d.tar.gz git-0721c314a5c8fddc877140ab5a333c42c62f780d.tar.xz | |
Use die_errno() instead of die() when checking syscalls
Lots of die() calls did not actually report the kind of error, which
can leave the user confused as to the real problem. Use die_errno()
where we check a system/library call that sets errno on failure, or
one of the following that wrap such calls:
Function Passes on error from
-------- --------------------
odb_pack_keep open
read_ancestry fopen
read_in_full xread
strbuf_read xread
strbuf_read_file open or strbuf_read_file
strbuf_readlink readlink
write_in_full xwrite
Signed-off-by: Thomas Rast <trast@student.ethz.ch>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-archive.c')
| -rw-r--r-- | builtin-archive.c | 4 |
1 files changed, 2 insertions, 2 deletions
diff --git a/builtin-archive.c b/builtin-archive.c index 3c5a5a782..f9a4bea41 100644 --- a/builtin-archive.c +++ b/builtin-archive.c @@ -13,10 +13,10 @@ static void create_output_file(const char *output_file) { int output_fd = open(output_file, O_CREAT | O_WRONLY | O_TRUNC, 0666); if (output_fd < 0) - die("could not create archive file: %s ", output_file); + die_errno("could not create archive file '%s'", output_file); if (output_fd != 1) { if (dup2(output_fd, 1) < 0) - die("could not redirect output"); + die_errno("could not redirect output"); else close(output_fd); } |