diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2008-03-02 21:35:10 -0500 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-03-03 00:05:45 -0800 |
| commit | 49d58fd0770cbb667a0d7532156ced803e482864 (patch) | |
| tree | a96773c74661b501d0c26c7d37da0daeb0a0f54d /builtin-fetch.c | |
| parent | c50b2b47999134a5da1f9a5ccb36855313e44e7d (diff) | |
| download | git-49d58fd0770cbb667a0d7532156ced803e482864.tar.gz git-49d58fd0770cbb667a0d7532156ced803e482864.tar.xz | |
Free the path_lists used to find non-local tags in git-fetch
To support calling find_non_local_tags() more than once in a single
git-fetch process we need the existing_refs to be stack-allocated
so it resets on the second call. We also should free the path
lists to avoid unnecessary memory leaking.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-fetch.c')
| -rw-r--r-- | builtin-fetch.c | 4 |
1 files changed, 3 insertions, 1 deletions
diff --git a/builtin-fetch.c b/builtin-fetch.c index 1d3ce775a..3758d4817 100644 --- a/builtin-fetch.c +++ b/builtin-fetch.c @@ -457,7 +457,7 @@ static void find_non_local_tags(struct transport *transport, struct ref **head, struct ref ***tail) { - static struct path_list existing_refs = { NULL, 0, 0, 0 }; + struct path_list existing_refs = { NULL, 0, 0, 0 }; struct path_list new_refs = { NULL, 0, 0, 1 }; char *ref_name; int ref_name_len; @@ -503,6 +503,8 @@ static void find_non_local_tags(struct transport *transport, } free(ref_name); } + path_list_clear(&existing_refs, 0); + path_list_clear(&new_refs, 0); } static int do_fetch(struct transport *transport, |