diff options
| author | Jim Meyering <jim@meyering.net> | 2008-01-04 18:37:41 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2008-01-04 12:28:58 -0800 |
| commit | 872c930dcb048c1a2b50e6ce881c521dcee15e23 (patch) | |
| tree | ccb4bc3d4d196327513108e59e3aeb76bfeeddbf /builtin-grep.c | |
| parent | 95bf4bd4f7280312571e642339f3571310d0d660 (diff) | |
| download | git-872c930dcb048c1a2b50e6ce881c521dcee15e23.tar.gz git-872c930dcb048c1a2b50e6ce881c521dcee15e23.tar.xz | |
Don't access line[-1] for a zero-length "line" from fgets.
A NUL byte at beginning of file, or just after a newline
would provoke an invalid buf[-1] access in a few places.
* builtin-grep.c (cmd_grep): Don't access buf[-1].
* builtin-pack-objects.c (get_object_list): Likewise.
* builtin-rev-list.c (read_revisions_from_stdin): Likewise.
* bundle.c (read_bundle_header): Likewise.
* server-info.c (read_pack_info_file): Likewise.
* transport.c (insert_packed_refs): Likewise.
Signed-off-by: Jim Meyering <meyering@redhat.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-grep.c')
| -rw-r--r-- | builtin-grep.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-grep.c b/builtin-grep.c index f1ff8dc55..0d6cc7361 100644 --- a/builtin-grep.c +++ b/builtin-grep.c @@ -644,7 +644,7 @@ int cmd_grep(int argc, const char **argv, const char *prefix) die("'%s': %s", argv[1], strerror(errno)); while (fgets(buf, sizeof(buf), patterns)) { int len = strlen(buf); - if (buf[len-1] == '\n') + if (len && buf[len-1] == '\n') buf[len-1] = 0; /* ignore empty line like grep does */ if (!buf[0]) |