diff options
| author | Jim Meyering <jim@meyering.net> | 2007-06-24 21:20:41 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2007-06-26 21:48:53 -0700 |
| commit | 91c8d5905c33e9d7c9014a1c6c7cec8eb86584df (patch) | |
| tree | c3dbbc16aa7df268aae8962bc4cac367fc5c51ca /builtin-init-db.c | |
| parent | 2275d502114c71045af991697048191fed88aac4 (diff) | |
| download | git-91c8d5905c33e9d7c9014a1c6c7cec8eb86584df.tar.gz git-91c8d5905c33e9d7c9014a1c6c7cec8eb86584df.tar.xz | |
detect close failure on just-written file handles
I audited git for potential undetected write failures.
In the cases fixed below, the diagnostics I add mimic the diagnostics
used in surrounding code, even when that means not reporting
the precise strerror(errno) cause of the error.
Signed-off-by: Jim Meyering <jim@meyering.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin-init-db.c')
| -rw-r--r-- | builtin-init-db.c | 3 |
1 files changed, 2 insertions, 1 deletions
diff --git a/builtin-init-db.c b/builtin-init-db.c index 0be2d2ef6..976f47b32 100644 --- a/builtin-init-db.c +++ b/builtin-init-db.c @@ -40,7 +40,8 @@ static int copy_file(const char *dst, const char *src, int mode) return fdo; } status = copy_fd(fdi, fdo); - close(fdo); + if (close(fdo) != 0) + return error("%s: write error: %s", dst, strerror(errno)); if (!status && adjust_shared_perm(dst)) return -1; |