diff options
author | Linus Torvalds <torvalds@osdl.org> | 2006-05-28 15:13:53 -0700 |
---|---|---|
committer | Junio C Hamano <junkio@cox.net> | 2006-05-28 19:40:18 -0700 |
commit | 097dc3d8c32f4b85bf9701d5e1de98999ac25c1c (patch) | |
tree | ff76950b6b938324ccc9ed0fc94e130d9df5de77 /builtin-ls-tree.c | |
parent | 2522c13244c13fe3a9f0769ea6294dce08e6596c (diff) | |
download | git-097dc3d8c32f4b85bf9701d5e1de98999ac25c1c.tar.gz git-097dc3d8c32f4b85bf9701d5e1de98999ac25c1c.tar.xz |
Remove "tree->entries" tree-entry list from tree parser
This finally removes the tree-entry list from "struct tree", since most of
the users can just use the tree-walk infrastructure to walk the raw tree
buffers instead of the tree-entry list.
The tree-entry list is inefficient, and generates tons of small
allocations for no good reason. The tree-walk infrastructure is generally
no harder to use than following a linked list, and allows us to do most
tree parsing in-place.
Some programs still use the old tree-entry lists, and are a bit painful to
convert without major surgery. For them we have a helper function that
creates a temporary tree-entry list on demand. We can convert those too
eventually, but with this they no longer affect any users who don't need
the explicit lists.
Signed-off-by: Linus Torvalds <torvalds@osdl.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'builtin-ls-tree.c')
-rw-r--r-- | builtin-ls-tree.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-ls-tree.c b/builtin-ls-tree.c index 48385d59f..b8d0d88ba 100644 --- a/builtin-ls-tree.c +++ b/builtin-ls-tree.c @@ -53,7 +53,7 @@ static int show_recursive(const char *base, int baselen, const char *pathname) } } -static int show_tree(unsigned char *sha1, const char *base, int baselen, +static int show_tree(const unsigned char *sha1, const char *base, int baselen, const char *pathname, unsigned mode, int stage) { int retval = 0; |