diff options
| author | Shawn O. Pearce <spearce@spearce.org> | 2006-12-30 21:55:15 -0500 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-12-30 22:22:14 -0800 |
| commit | 9b0b50936ec76ad8e582d18d5bf54bc81c685e9b (patch) | |
| tree | 1599e84bb2e53adbce3728f62d1c3c38d815a1e9 /builtin-push.c | |
| parent | ad1a382fbb3ecb1bb017854a470816c815cc46c9 (diff) | |
| download | git-9b0b50936ec76ad8e582d18d5bf54bc81c685e9b.tar.gz git-9b0b50936ec76ad8e582d18d5bf54bc81c685e9b.tar.xz | |
Remove unnecessary argc parameter from run_command_v.
The argc parameter is never used by the run_command_v family of
functions. Instead they require that the passed argv[] be NULL
terminated so they can rely on the operating system's execvp
function to correctly pass the arguments to the new process.
Making the caller pass the argc is just confusing, as the caller
could be mislead into believing that the argc might take precendece
over the argv, or that the argv does not need to be NULL terminated.
So goodbye argc. Don't come back.
Signed-off-by: Shawn O. Pearce <spearce@spearce.org>
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'builtin-push.c')
| -rw-r--r-- | builtin-push.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin-push.c b/builtin-push.c index b7412e829..7a3d2bb06 100644 --- a/builtin-push.c +++ b/builtin-push.c @@ -275,7 +275,7 @@ static int do_push(const char *repo) argv[dest_argc] = NULL; if (verbose) fprintf(stderr, "Pushing to %s\n", dest); - err = run_command_v(argc, argv); + err = run_command_v(argv); if (!err) continue; switch (err) { |