diff options
| author | Junio C Hamano <gitster@pobox.com> | 2015-02-24 22:09:54 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-02-24 22:09:54 -0800 |
| commit | faf723a631aff822b4808c496c0970edb0ca2a99 (patch) | |
| tree | 6ac7646bf0e31bc5ee177b358a8cdda5ea7d3fc6 /builtin/commit.c | |
| parent | 9874fca7122563e28d699a911404fc49d2a24f1c (diff) | |
| parent | a46442f1675722eb68238b329a4a285f03f41dda (diff) | |
| download | git-faf723a631aff822b4808c496c0970edb0ca2a99.tar.gz git-faf723a631aff822b4808c496c0970edb0ca2a99.tar.xz | |
Merge branch 'jk/blame-commit-label' into maint
"git blame HEAD -- missing" failed to correctly say "HEAD" when it
tried to say "No such path 'missing' in HEAD".
* jk/blame-commit-label:
blame.c: fix garbled error message
use xstrdup_or_null to replace ternary conditionals
builtin/commit.c: use xstrdup_or_null instead of envdup
builtin/apply.c: use xstrdup_or_null instead of null_strdup
git-compat-util: add xstrdup_or_null helper
Diffstat (limited to 'builtin/commit.c')
| -rw-r--r-- | builtin/commit.c | 12 |
1 files changed, 3 insertions, 9 deletions
diff --git a/builtin/commit.c b/builtin/commit.c index 7d90c3591..5cd1478eb 100644 --- a/builtin/commit.c +++ b/builtin/commit.c @@ -559,20 +559,14 @@ static void set_ident_var(char **buf, char *val) *buf = val; } -static char *envdup(const char *var) -{ - const char *val = getenv(var); - return val ? xstrdup(val) : NULL; -} - static void determine_author_info(struct strbuf *author_ident) { char *name, *email, *date; struct ident_split author; - name = envdup("GIT_AUTHOR_NAME"); - email = envdup("GIT_AUTHOR_EMAIL"); - date = envdup("GIT_AUTHOR_DATE"); + name = xstrdup_or_null(getenv("GIT_AUTHOR_NAME")); + email = xstrdup_or_null(getenv("GIT_AUTHOR_EMAIL")); + date = xstrdup_or_null(getenv("GIT_AUTHOR_DATE")); if (author_message) { struct ident_split ident; |