diff options
| author | Clemens Buchacher <drizzd@aon.at> | 2011-09-04 12:41:59 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2011-09-06 12:50:10 -0700 |
| commit | 5879f5684cfe8a38326b4ffd078f96e35c68e640 (patch) | |
| tree | 23b8f003c9692debdfbbc4b40f35d0c26920dddc /builtin/ls-files.c | |
| parent | 8894d5358095a08c2f700a87ce9fdefb0b6eb61b (diff) | |
| download | git-5879f5684cfe8a38326b4ffd078f96e35c68e640.tar.gz git-5879f5684cfe8a38326b4ffd078f96e35c68e640.tar.xz | |
remove prefix argument from pathspec_prefix
Passing a prefix to a function that is supposed to find the prefix is
strange. And it's really only used if the pathspec is NULL. Make the
callers handle this case instead.
As we are always returning a fresh copy of a string (or NULL), change the
type of the returned value to non-const "char *".
Signed-off-by: Clemens Buchacher <drizzd@aon.at>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/ls-files.c')
| -rw-r--r-- | builtin/ls-files.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/ls-files.c b/builtin/ls-files.c index 0e98bff0c..19e53cc88 100644 --- a/builtin/ls-files.c +++ b/builtin/ls-files.c @@ -541,7 +541,7 @@ int cmd_ls_files(int argc, const char **argv, const char *cmd_prefix) strip_trailing_slash_from_submodules(); /* Find common prefix for all pathspec's */ - max_prefix = pathspec_prefix(prefix, pathspec); + max_prefix = pathspec_prefix(pathspec); max_prefix_len = max_prefix ? strlen(max_prefix) : 0; /* Treat unmatching pathspec elements as errors */ |