diff options
| author | Jeff King <peff@peff.net> | 2014-07-24 00:41:11 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2014-07-24 13:57:49 -0700 |
| commit | 28b3563241ac13733781fb0bada37f776a39f43d (patch) | |
| tree | cd78612af838e155c552b5ea5a10fe691e627e6d /builtin/rev-parse.c | |
| parent | d51428bf17e9f17071836350299e256cac2d503a (diff) | |
| download | git-28b3563241ac13733781fb0bada37f776a39f43d.tar.gz git-28b3563241ac13733781fb0bada37f776a39f43d.tar.xz | |
free ref string returned by dwim_ref
A call to "dwim_ref(name, len, flags, &ref)" will allocate a
new string in "ref" to return the exact ref we found. We do
not consistently free it in all code paths, leading to small
leaks. The worst is in get_sha1_basic, which may be called
many times (e.g., by "cat-file --batch"), though it is
relatively unlikely, as it only triggers on a bogus reflog
specification.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin/rev-parse.c')
| -rw-r--r-- | builtin/rev-parse.c | 1 |
1 files changed, 1 insertions, 0 deletions
diff --git a/builtin/rev-parse.c b/builtin/rev-parse.c index 1a6122d3a..0bce2a63d 100644 --- a/builtin/rev-parse.c +++ b/builtin/rev-parse.c @@ -150,6 +150,7 @@ static void show_rev(int type, const unsigned char *sha1, const char *name) error("refname '%s' is ambiguous", name); break; } + free(full); } else { show_with_type(type, name); } |