diff options
author | Ævar Arnfjörð Bjarmason <avarab@gmail.com> | 2011-12-21 01:18:20 +0000 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2011-12-21 10:19:40 -0800 |
commit | 952fba9c63417d19e01fdf0b714f01b8ae9f3618 (patch) | |
tree | b819d51bf6072f894cd0f1e7abf4e69ccfecca43 /builtin | |
parent | d7a10c3140de593abe25d55bbdba43373079e82e (diff) | |
download | git-952fba9c63417d19e01fdf0b714f01b8ae9f3618.tar.gz git-952fba9c63417d19e01fdf0b714f01b8ae9f3618.tar.xz |
Fix a bitwise negation assignment issue spotted by Sun Studio
Change direct and indirect assignments of the bitwise negation of 0 to
uint32_t variables to have a "U" suffix. I.e. ~0U instead of ~0. This
eliminates warnings under Sun Studio 12 Update 1:
"vcs-svn/string_pool.c", line 11: warning: initializer will be sign-extended: -1 (E_INIT_SIGN_EXTEND)
"vcs-svn/string_pool.c", line 81: warning: initializer will be sign-extended: -1 (E_INIT_SIGN_EXTEND)
"vcs-svn/repo_tree.c", line 112: warning: initializer will be sign-extended: -1 (E_INIT_SIGN_EXTEND)
"vcs-svn/repo_tree.c", line 112: warning: initializer will be sign-extended: -1 (E_INIT_SIGN_EXTEND)
"test-treap.c", line 34: warning: initializer will be sign-extended: -1 (E_INIT_SIGN_EXTEND)
The semantics are still the same as demonstrated by this program:
$ cat test.c && make test && ./test
#include <stdio.h>
#include <stdint.h>
int main(void)
{
uint32_t foo = ~0;
uint32_t bar = ~0U;
printf("foo = <%u> bar = <%u>\n", foo, bar);
return 0;
}
cc test.c -o test
"test.c", line 5: warning: initializer will be sign-extended: -1
foo = <4294967295> bar = <4294967295>
Signed-off-by: Ævar Arnfjörð Bjarmason <avarab@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
0 files changed, 0 insertions, 0 deletions