diff options
| author | Aaron Schrab <aaron@schrab.com> | 2013-04-08 18:46:39 -0400 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2013-04-08 20:57:43 -0700 |
| commit | 0658569eb03e743ef46abd06abd9d0d81d53e72c (patch) | |
| tree | 4e439efb9f5f3f74a130f92d7dc63737485ffe6f /builtin | |
| parent | 52a3e011c779456e63b6274af0024eeb92dd7888 (diff) | |
| download | git-0658569eb03e743ef46abd06abd9d0d81d53e72c.tar.gz git-0658569eb03e743ef46abd06abd9d0d81d53e72c.tar.xz | |
clone: Fix error message for reference repository
Do not report that an argument to clone's --reference option is not a
local directory. Nothing checks for the existence or type of the path
as supplied by the user; checks are only done for particular contents of
the supposed directory, so we have no way to know the status of the
supplied path. Telling the user that a directory doesn't exist when
that isn't actually known may lead him or her on the wrong path to
finding the problem.
Instead just state that the entered path is not a local repository which
is really all that is known about it. It could be more helpful to state
the actual paths which were checked, but I believe that giving a good
description of that would be too verbose for a simple error message and
would be too dependent on implementation details.
Signed-off-by: Aaron Schrab <aaron@schrab.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/clone.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/builtin/clone.c b/builtin/clone.c index f9c380eb6..0a1e0bf5a 100644 --- a/builtin/clone.c +++ b/builtin/clone.c @@ -241,7 +241,7 @@ static int add_one_reference(struct string_list_item *item, void *cb_data) free(ref_git); ref_git = ref_git_git; } else if (!is_directory(mkpath("%s/objects", ref_git))) - die(_("reference repository '%s' is not a local directory."), + die(_("reference repository '%s' is not a local repository."), item->string); strbuf_addf(&alternate, "%s/objects", ref_git); |