diff options
| author | René Scharfe <l.s.r@web.de> | 2017-01-28 22:40:58 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2017-01-30 14:17:00 -0800 |
| commit | 35d803bc9a0d21c36b1381f6e42455beeb73b715 (patch) | |
| tree | 045fa1fa1b75d7477bcd6e49f9ea2a75a9211732 /builtin | |
| parent | db101991414f4e14b3763b4843dddcca6b31b40b (diff) | |
| download | git-35d803bc9a0d21c36b1381f6e42455beeb73b715.tar.gz git-35d803bc9a0d21c36b1381f6e42455beeb73b715.tar.xz | |
use SWAP macro
Apply the semantic patch swap.cocci to convert hand-rolled swaps to use
the macro SWAP. The resulting code is shorter and easier to read, the
object code is effectively unchanged.
The patch for object.c had to be hand-edited in order to preserve the
comment before the change; Coccinelle tried to eat it for some reason.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'builtin')
| -rw-r--r-- | builtin/diff-tree.c | 4 | ||||
| -rw-r--r-- | builtin/diff.c | 9 |
2 files changed, 4 insertions, 9 deletions
diff --git a/builtin/diff-tree.c b/builtin/diff-tree.c index 806dd7a88..8ce00480c 100644 --- a/builtin/diff-tree.c +++ b/builtin/diff-tree.c @@ -147,9 +147,7 @@ int cmd_diff_tree(int argc, const char **argv, const char *prefix) tree1 = opt->pending.objects[0].item; tree2 = opt->pending.objects[1].item; if (tree2->flags & UNINTERESTING) { - struct object *tmp = tree2; - tree2 = tree1; - tree1 = tmp; + SWAP(tree2, tree1); } diff_tree_sha1(tree1->oid.hash, tree2->oid.hash, diff --git a/builtin/diff.c b/builtin/diff.c index 7f91f6d22..3d64b8533 100644 --- a/builtin/diff.c +++ b/builtin/diff.c @@ -45,12 +45,9 @@ static void stuff_change(struct diff_options *opt, return; if (DIFF_OPT_TST(opt, REVERSE_DIFF)) { - unsigned tmp; - const unsigned char *tmp_u; - const char *tmp_c; - tmp = old_mode; old_mode = new_mode; new_mode = tmp; - tmp_u = old_sha1; old_sha1 = new_sha1; new_sha1 = tmp_u; - tmp_c = old_name; old_name = new_name; new_name = tmp_c; + SWAP(old_mode, new_mode); + SWAP(old_sha1, new_sha1); + SWAP(old_name, new_name); } if (opt->prefix && |