aboutsummaryrefslogtreecommitdiff
path: root/bundle.c
diff options
context:
space:
mode:
authorJim Meyering <jim@meyering.net>2008-01-04 18:37:41 +0100
committerJunio C Hamano <gitster@pobox.com>2008-01-04 12:28:58 -0800
commit872c930dcb048c1a2b50e6ce881c521dcee15e23 (patch)
treeccb4bc3d4d196327513108e59e3aeb76bfeeddbf /bundle.c
parent95bf4bd4f7280312571e642339f3571310d0d660 (diff)
downloadgit-872c930dcb048c1a2b50e6ce881c521dcee15e23.tar.gz
git-872c930dcb048c1a2b50e6ce881c521dcee15e23.tar.xz
Don't access line[-1] for a zero-length "line" from fgets.
A NUL byte at beginning of file, or just after a newline would provoke an invalid buf[-1] access in a few places. * builtin-grep.c (cmd_grep): Don't access buf[-1]. * builtin-pack-objects.c (get_object_list): Likewise. * builtin-rev-list.c (read_revisions_from_stdin): Likewise. * bundle.c (read_bundle_header): Likewise. * server-info.c (read_pack_info_file): Likewise. * transport.c (insert_packed_refs): Likewise. Signed-off-by: Jim Meyering <meyering@redhat.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'bundle.c')
-rw-r--r--bundle.c2
1 files changed, 1 insertions, 1 deletions
diff --git a/bundle.c b/bundle.c
index 9b9b9166d..be204d8a2 100644
--- a/bundle.c
+++ b/bundle.c
@@ -48,7 +48,7 @@ int read_bundle_header(const char *path, struct bundle_header *header)
: &header->references;
char delim;
- if (buffer[len - 1] == '\n')
+ if (len && buffer[len - 1] == '\n')
buffer[len - 1] = '\0';
if (get_sha1_hex(buffer + offset, sha1)) {
warning("unrecognized header: %s", buffer);