diff options
author | Jeff King <peff@peff.net> | 2014-02-24 02:39:45 -0500 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2014-02-24 10:12:58 -0800 |
commit | 7ca36d9398a85e7974d04f8fbd2c6adb088290e1 (patch) | |
tree | e3ef065ab5fee09448ad78239edefb09c9ca927a /cache.h | |
parent | d4b8de0420ffcc7a654ddc6c69a96d3c1b25b4fa (diff) | |
download | git-7ca36d9398a85e7974d04f8fbd2c6adb088290e1.tar.gz git-7ca36d9398a85e7974d04f8fbd2c6adb088290e1.tar.xz |
date: check date overflow against time_t
When we check whether a timestamp has overflowed, we check
only against ULONG_MAX, meaning that strtoul has overflowed.
However, we also feed these timestamps to system functions
like gmtime, which expect a time_t. On many systems, time_t
is actually smaller than "unsigned long" (e.g., because it
is signed), and we would overflow when using these
functions. We don't know the actual size or signedness of
time_t, but we can easily check for truncation with a simple
assignment.
Signed-off-by: Jeff King <peff@peff.net>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'cache.h')
-rw-r--r-- | cache.h | 1 |
1 files changed, 1 insertions, 0 deletions
@@ -909,6 +909,7 @@ void datestamp(char *buf, int bufsize); unsigned long approxidate_careful(const char *, int *); unsigned long approxidate_relative(const char *date, const struct timeval *now); enum date_mode parse_date_format(const char *format); +int date_overflows(unsigned long date); #define IDENT_STRICT 1 #define IDENT_NO_DATE 2 |