aboutsummaryrefslogtreecommitdiff
path: root/compat
diff options
context:
space:
mode:
authorNicolas Pitre <nico@cam.org>2009-08-18 15:26:55 -0400
committerJunio C Hamano <gitster@pobox.com>2009-08-18 14:16:37 -0700
commit51ea55190b6e72c77c96754c1bf2f149a4714848 (patch)
treea8f4a6fa1f05c0080c926432905e6e66ccbfadeb /compat
parentd5f6a96fa4792f6143d06d9c0b572a96d7235305 (diff)
downloadgit-51ea55190b6e72c77c96754c1bf2f149a4714848.tar.gz
git-51ea55190b6e72c77c96754c1bf2f149a4714848.tar.xz
make sure byte swapping is optimal for git
We rely on ntohl() and htonl() to perform byte swapping in many places. However, some platforms have libraries providing really poor implementations of those which might cause significant performance issues, especially with the block-sha1 code. Signed-off-by: Nicolas Pitre <nico@cam.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'compat')
-rw-r--r--compat/bswap.h36
1 files changed, 36 insertions, 0 deletions
diff --git a/compat/bswap.h b/compat/bswap.h
new file mode 100644
index 000000000..7246a12c6
--- /dev/null
+++ b/compat/bswap.h
@@ -0,0 +1,36 @@
+/*
+ * Let's make sure we always have a sane definition for ntohl()/htonl().
+ * Some libraries define those as a function call, just to perform byte
+ * shifting, bringing significant overhead to what should be a simple
+ * operation.
+ */
+
+/*
+ * Default version that the compiler ought to optimize properly with
+ * constant values.
+ */
+static inline unsigned int default_swab32(unsigned int val)
+{
+ return (((val & 0xff000000) >> 24) |
+ ((val & 0x00ff0000) >> 8) |
+ ((val & 0x0000ff00) << 8) |
+ ((val & 0x000000ff) << 24));
+}
+
+#if defined(__GNUC__) && (defined(__i386__) || defined(__x86_64__))
+
+#define bswap32(x) ({ \
+ unsigned int __res; \
+ if (__builtin_constant_p(x)) { \
+ __res = default_swab32(x); \
+ } else { \
+ __asm__("bswap %0" : "=r" (__res) : "0" (x)); \
+ } \
+ __res; })
+
+#undef ntohl
+#undef htonl
+#define ntohl(x) bswap32(x)
+#define htonl(x) bswap32(x)
+
+#endif