diff options
| author | Junio C Hamano <junkio@cox.net> | 2006-02-22 03:47:20 -0800 |
|---|---|---|
| committer | Junio C Hamano <junkio@cox.net> | 2006-02-22 03:47:20 -0800 |
| commit | d27d5b3c5b97ca30dfc5c448dc8cdae914131051 (patch) | |
| tree | 2dd596f509cc398e5e8f28f014852d3fa1e996e4 /contrib/gitview | |
| parent | 50319850343dfe534939ee6b38507d5a8fc44b50 (diff) | |
| download | git-d27d5b3c5b97ca30dfc5c448dc8cdae914131051.tar.gz git-d27d5b3c5b97ca30dfc5c448dc8cdae914131051.tar.xz | |
gitview: ls-remote invocation shellquote safety.
This will allow you to point GIT_DIR at directories with funny names.
Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'contrib/gitview')
| -rwxr-xr-x | contrib/gitview/gitview | 6 |
1 files changed, 1 insertions, 5 deletions
diff --git a/contrib/gitview/gitview b/contrib/gitview/gitview index 5c338c022..4b52eb7dc 100755 --- a/contrib/gitview/gitview +++ b/contrib/gitview/gitview @@ -454,11 +454,7 @@ class GitView: self.bt_sha1 = { } ls_remote = re.compile('^(.{40})\trefs/([^^]+)(?:\\^(..))?$'); - git_dir = os.getenv("GIT_DIR") - if (git_dir == None): - git_dir = ".git" - - fp = os.popen('git ls-remote ' + git_dir) + fp = os.popen('git ls-remote "${GIT_DIR-.git}"') while 1: line = string.strip(fp.readline()) if line == '': |