diff options
| author | Elia Pinto <gitter.spiros@gmail.com> | 2015-12-22 15:10:23 +0100 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2015-12-27 15:33:13 -0800 |
| commit | a22c9e8d9e29277f51b77aff8d0eee3945577e72 (patch) | |
| tree | 86a75e3ea77e8875fb667623a5d434c8b63a723e /contrib | |
| parent | 554f6e41067b9e3e565b6988a8294fac1cb78f4b (diff) | |
| download | git-a22c9e8d9e29277f51b77aff8d0eee3945577e72.tar.gz git-a22c9e8d9e29277f51b77aff8d0eee3945577e72.tar.xz | |
contrib/examples/git-commit.sh: use the $( ... ) construct for command substitution
The Git CodingGuidelines prefer the $(...) construct for command
substitution instead of using the backquotes `...`.
The backquoted form is the traditional method for command
substitution, and is supported by POSIX. However, all but the
simplest uses become complicated quickly. In particular, embedded
command substitutions and/or the use of double quotes require
careful escaping with the backslash character.
The patch was generated by:
for _f in $(find . -name "*.sh")
do
perl -i -pe 'BEGIN{undef $/;} s/`(.+?)`/\$(\1)/smg' "${_f}"
done
and then carefully proof-read.
Signed-off-by: Elia Pinto <gitter.spiros@gmail.com>
Reviewed-by: Jonathan Nieder <jrnieder@gmail.com>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
| -rwxr-xr-x | contrib/examples/git-commit.sh | 8 |
1 files changed, 4 insertions, 4 deletions
diff --git a/contrib/examples/git-commit.sh b/contrib/examples/git-commit.sh index 934505bab..86c9cfa0c 100755 --- a/contrib/examples/git-commit.sh +++ b/contrib/examples/git-commit.sh @@ -574,10 +574,10 @@ then if test "$templatefile" != "" then # Test whether this is just the unaltered template. - if cnt=`sed -e '/^#/d' < "$templatefile" | + if cnt=$(sed -e '/^#/d' < "$templatefile" | git stripspace | diff "$GIT_DIR"/COMMIT_BAREMSG - | - wc -l` && + wc -l) && test 0 -lt $cnt then have_commitmsg=t @@ -630,8 +630,8 @@ then fi if test -z "$quiet" then - commit=`git diff-tree --always --shortstat --pretty="format:%h: %s"\ - --abbrev --summary --root HEAD --` + commit=$(git diff-tree --always --shortstat --pretty="format:%h: %s"\ + --abbrev --summary --root HEAD --) echo "Created${initial_commit:+ initial} commit $commit" fi fi |