diff options
author | René Scharfe <l.s.r@web.de> | 2016-09-27 21:08:21 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2016-09-27 14:02:40 -0700 |
commit | 92d52fab3af8b1d5231285ac13b364f008d1a886 (patch) | |
tree | d7f4350b084aee1109cb4fe328b2892a16026e34 /contrib | |
parent | 7f2817daef616e764afaaf302f85beb7a13e56dc (diff) | |
download | git-92d52fab3af8b1d5231285ac13b364f008d1a886.tar.gz git-92d52fab3af8b1d5231285ac13b364f008d1a886.tar.xz |
use strbuf_addstr() instead of strbuf_addf() with "%s", part 2
Replace uses of strbuf_addf() for adding strings with more lightweight
strbuf_addstr() calls. This is shorter and makes the intent clearer.
bc57b9c0cc5a123365a922fa1831177e3fd607ed already converted three cases,
this patch covers two more.
A semantic patch for Coccinelle is included for easier checking for
new cases that might be introduced in the future.
Signed-off-by: Rene Scharfe <l.s.r@web.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'contrib')
-rw-r--r-- | contrib/coccinelle/strbuf.cocci | 6 |
1 files changed, 6 insertions, 0 deletions
diff --git a/contrib/coccinelle/strbuf.cocci b/contrib/coccinelle/strbuf.cocci index 7932d48cd..4b7553f83 100644 --- a/contrib/coccinelle/strbuf.cocci +++ b/contrib/coccinelle/strbuf.cocci @@ -3,3 +3,9 @@ expression E1, E2; @@ - strbuf_addf(E1, E2); + strbuf_addstr(E1, E2); + +@@ +expression E1, E2; +@@ +- strbuf_addf(E1, "%s", E2); ++ strbuf_addstr(E1, E2); |