diff options
| author | Junio C Hamano <gitster@pobox.com> | 2016-10-10 14:03:46 -0700 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2016-10-10 14:03:46 -0700 |
| commit | b8688adb12d086b161aa7c369126bdd56843a01b (patch) | |
| tree | c1d649861b902b5d72dcd8a0d3d970a2294bf5ef /contrib | |
| parent | a23ca1b8dc42ffd4de2ef30d67ce1e21ded29886 (diff) | |
| parent | 7e65c75c31de751f58945a22e91e120c10ab6e87 (diff) | |
| download | git-b8688adb12d086b161aa7c369126bdd56843a01b.tar.gz git-b8688adb12d086b161aa7c369126bdd56843a01b.tar.xz | |
Merge branch 'rs/qsort'
We call "qsort(array, nelem, sizeof(array[0]), fn)", and most of
the time third parameter is redundant. A new QSORT() macro lets us
omit it.
* rs/qsort:
show-branch: use QSORT
use QSORT, part 2
coccicheck: use --all-includes by default
remove unnecessary check before QSORT
use QSORT
add QSORT
Diffstat (limited to 'contrib')
| -rw-r--r-- | contrib/coccinelle/qsort.cocci | 37 |
1 files changed, 37 insertions, 0 deletions
diff --git a/contrib/coccinelle/qsort.cocci b/contrib/coccinelle/qsort.cocci new file mode 100644 index 000000000..22b93a996 --- /dev/null +++ b/contrib/coccinelle/qsort.cocci @@ -0,0 +1,37 @@ +@@ +expression base, nmemb, compar; +@@ +- qsort(base, nmemb, sizeof(*base), compar); ++ QSORT(base, nmemb, compar); + +@@ +expression base, nmemb, compar; +@@ +- qsort(base, nmemb, sizeof(base[0]), compar); ++ QSORT(base, nmemb, compar); + +@@ +type T; +T *base; +expression nmemb, compar; +@@ +- qsort(base, nmemb, sizeof(T), compar); ++ QSORT(base, nmemb, compar); + +@@ +expression base, nmemb, compar; +@@ +- if (nmemb) + QSORT(base, nmemb, compar); + +@@ +expression base, nmemb, compar; +@@ +- if (nmemb > 0) + QSORT(base, nmemb, compar); + +@@ +expression base, nmemb, compar; +@@ +- if (nmemb > 1) + QSORT(base, nmemb, compar); |