diff options
| author | René Scharfe <rene.scharfe@lsrfire.ath.cx> | 2007-07-07 20:19:08 +0200 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2007-07-07 11:53:49 -0700 |
| commit | 4d3f4b80e49275c7eaf6ba0dbddd6180957926b9 (patch) | |
| tree | 0e24145e4a92f33d95844c0509c0e95a95f1d9a3 /diff-lib.c | |
| parent | 34a3e695497ab2abbf2fc33a46380accaa8c7c15 (diff) | |
| download | git-4d3f4b80e49275c7eaf6ba0dbddd6180957926b9.tar.gz git-4d3f4b80e49275c7eaf6ba0dbddd6180957926b9.tar.xz | |
diff-lib.c: don't strdup twice
The static function read_directory in diff-lib.c is only ever called
with struct path_list lists with .strdup_paths turned on, i.e.
path_list_insert will strdup the paths for us (again). Let's take
advantage of that and stop doing it twice.
Signed-off-by: Rene Scharfe <rene.scharfe@lsrfire.ath.cx>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'diff-lib.c')
| -rw-r--r-- | diff-lib.c | 2 |
1 files changed, 1 insertions, 1 deletions
diff --git a/diff-lib.c b/diff-lib.c index 7fb19c7b8..92c0e39ad 100644 --- a/diff-lib.c +++ b/diff-lib.c @@ -24,7 +24,7 @@ static int read_directory(const char *path, struct path_list *list) while ((e = readdir(dir))) if (strcmp(".", e->d_name) && strcmp("..", e->d_name)) - path_list_insert(xstrdup(e->d_name), list); + path_list_insert(e->d_name, list); closedir(dir); return 0; |