diff options
author | Pierre Habouzit <madcoder@debian.org> | 2007-09-10 12:35:04 +0200 |
---|---|---|
committer | Junio C Hamano <gitster@pobox.com> | 2007-09-10 12:48:24 -0700 |
commit | f1696ee398e92bcea3cdc7b3da85d8e0f77f6c50 (patch) | |
tree | 5951ed29b6f7bc887c4e5c75bf87b258232d1a76 /diff.c | |
parent | ddb95de33e99d547c3b533aea12f18c9e4dd649e (diff) | |
download | git-f1696ee398e92bcea3cdc7b3da85d8e0f77f6c50.tar.gz git-f1696ee398e92bcea3cdc7b3da85d8e0f77f6c50.tar.xz |
Strbuf API extensions and fixes.
* Add strbuf_rtrim to remove trailing spaces.
* Add strbuf_insert to insert data at a given position.
* Off-by one fix in strbuf_addf: strbuf_avail() does not counts the final
\0 so the overflow test for snprintf is the strict comparison. This is
not critical as the growth mechanism chosen will always allocate _more_
memory than asked, so the second test will not fail. It's some kind of
miracle though.
* Add size extension hints for strbuf_init and strbuf_read. If 0, default
applies, else:
+ initial buffer has the given size for strbuf_init.
+ first growth checks it has at least this size rather than the
default 8192.
Signed-off-by: Pierre Habouzit <madcoder@debian.org>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'diff.c')
-rw-r--r-- | diff.c | 4 |
1 files changed, 2 insertions, 2 deletions
@@ -1548,8 +1548,8 @@ static int populate_from_stdin(struct diff_filespec *s) { struct strbuf buf; - strbuf_init(&buf); - if (strbuf_read(&buf, 0) < 0) + strbuf_init(&buf, 0); + if (strbuf_read(&buf, 0, 0) < 0) return error("error while reading from stdin %s", strerror(errno)); |