aboutsummaryrefslogtreecommitdiff
path: root/diff.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2010-01-18 21:37:12 -0800
committerJunio C Hamano <gitster@pobox.com>2010-01-18 21:37:12 -0800
commit03c6e97f809e5b89089a2c689d6a319e8d471455 (patch)
tree35c4f6f2b801f9979feb2aee65578b575bac39bd /diff.c
parentc8cba79181abc139d7cba364bf868875426fc2c1 (diff)
parent814035c12a07927ea03350184a14f869cdce7276 (diff)
downloadgit-03c6e97f809e5b89089a2c689d6a319e8d471455.tar.gz
git-03c6e97f809e5b89089a2c689d6a319e8d471455.tar.xz
Merge branch 'maint-1.6.4' into maint-1.6.5
* maint-1.6.4: Fix mis-backport of t7002 base85: Make the code more obvious instead of explaining the non-obvious base85: encode_85() does not use the decode table base85 debug code: Fix length byte calculation checkout -m: do not try to fall back to --merge from an unborn branch branch: die explicitly why when calling "git branch [-a|-r] branchname". textconv: stop leaking file descriptors commit: --cleanup is a message option git count-objects: handle packs bigger than 4G t7102: make the test fail if one of its check fails
Diffstat (limited to 'diff.c')
-rw-r--r--diff.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/diff.c b/diff.c
index 72f25b528..17a2b4df2 100644
--- a/diff.c
+++ b/diff.c
@@ -3720,11 +3720,13 @@ static char *run_textconv(const char *pgm, struct diff_filespec *spec,
if (start_command(&child) != 0 ||
strbuf_read(&buf, child.out, 0) < 0 ||
finish_command(&child) != 0) {
+ close(child.out);
strbuf_release(&buf);
remove_tempfile();
error("error running textconv command '%s'", pgm);
return NULL;
}
+ close(child.out);
remove_tempfile();
return strbuf_detach(&buf, outsize);