aboutsummaryrefslogtreecommitdiff
path: root/diff.c
diff options
context:
space:
mode:
authorJunio C Hamano <gitster@pobox.com>2010-01-18 21:29:47 -0800
committerJunio C Hamano <gitster@pobox.com>2010-01-18 21:29:47 -0800
commit011c181cc656c8b3e48882729d1b6238e8c5c537 (patch)
tree4f4a1c516c474ed6ff0327f852e783d0efa53667 /diff.c
parentba7e81430a32614982172c7064c01db43f55b4bb (diff)
parentc5034673fd92b6278e6c9d55683770ec01fafc89 (diff)
downloadgit-011c181cc656c8b3e48882729d1b6238e8c5c537.tar.gz
git-011c181cc656c8b3e48882729d1b6238e8c5c537.tar.xz
Merge branch 'maint-1.6.2' into maint-1.6.3
* maint-1.6.2: base85: Make the code more obvious instead of explaining the non-obvious base85: encode_85() does not use the decode table base85 debug code: Fix length byte calculation checkout -m: do not try to fall back to --merge from an unborn branch branch: die explicitly why when calling "git branch [-a|-r] branchname". textconv: stop leaking file descriptors commit: --cleanup is a message option git count-objects: handle packs bigger than 4G t7102: make the test fail if one of its check fails Conflicts: diff.c
Diffstat (limited to 'diff.c')
-rw-r--r--diff.c2
1 files changed, 2 insertions, 0 deletions
diff --git a/diff.c b/diff.c
index f0b580c15..ad5c0a20e 100644
--- a/diff.c
+++ b/diff.c
@@ -3590,11 +3590,13 @@ static char *run_textconv(const char *pgm, struct diff_filespec *spec,
if (start_command(&child) != 0 ||
strbuf_read(&buf, child.out, 0) < 0 ||
finish_command(&child) != 0) {
+ close(child.out);
strbuf_release(&buf);
remove_tempfile();
error("error running textconv command '%s'", pgm);
return NULL;
}
+ close(child.out);
remove_tempfile();
return strbuf_detach(&buf, outsize);