diff options
| author | Junio C Hamano <gitster@pobox.com> | 2007-11-15 00:39:57 -0800 |
|---|---|---|
| committer | Junio C Hamano <gitster@pobox.com> | 2007-11-16 01:35:58 -0800 |
| commit | e23cb8c0cc0fb9f18e7e7106e2eec692a7b10044 (patch) | |
| tree | de5b32e6c7b468a1325689040b256e8bf804964b /git-bisect.sh | |
| parent | 947a604b01a8e81b3d0341d38fbf891289f3c0bb (diff) | |
| download | git-e23cb8c0cc0fb9f18e7e7106e2eec692a7b10044.tar.gz git-e23cb8c0cc0fb9f18e7e7106e2eec692a7b10044.tar.xz | |
git-bisect: war on "sed"
We do not need to pipe "echo" to "sed" only to strip refs/heads/
from the beginning. We are assuming not-so-ancient shells these
days.
Also there is no need to avoid assuming \012 is the LF; we do
not run on EBCDIC, sorry. Other parts of the script already
uses tr to convert separator to LF that way.
Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-bisect.sh')
| -rwxr-xr-x | git-bisect.sh | 5 |
1 files changed, 2 insertions, 3 deletions
diff --git a/git-bisect.sh b/git-bisect.sh index 46a7b8d54..3a210335e 100755 --- a/git-bisect.sh +++ b/git-bisect.sh @@ -71,7 +71,7 @@ bisect_start() { ;; refs/heads/*) [ -s "$GIT_DIR/head-name" ] && die "won't bisect on seeked tree" - echo "$head" | sed 's#^refs/heads/##' >"$GIT_DIR/head-name" + echo "${head#refs/heads/}" >"$GIT_DIR/head-name" ;; *) die "Bad HEAD - strange symbolic ref" @@ -275,8 +275,7 @@ exit_if_skipped_commits () { if expr "$_tried" : ".*[|].*" > /dev/null ; then echo "There are only 'skip'ped commit left to test." echo "The first bad commit could be any of:" - echo "$_tried" | sed -e 's/[|]/\ -/g' + echo "$_tried" | tr '[|]' '[\012]' echo "We cannot bisect more!" exit 2 fi |