aboutsummaryrefslogtreecommitdiff
path: root/git-p4.py
diff options
context:
space:
mode:
authorPete Wyckoff <pw@padd.com>2013-01-26 22:11:22 -0500
committerJunio C Hamano <gitster@pobox.com>2013-01-26 22:00:40 -0800
commit2abba3014e54920762eb81236e394af7b152f74c (patch)
treeb98c9040b175f509e9519202285169a42ea90fd4 /git-p4.py
parentc7d34884ae1d37e910ce6813c9baeb06c0912228 (diff)
downloadgit-2abba3014e54920762eb81236e394af7b152f74c.tar.gz
git-2abba3014e54920762eb81236e394af7b152f74c.tar.xz
git p4: avoid shell when invoking git config --get-all
Signed-off-by: Pete Wyckoff <pw@padd.com> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-p4.py')
-rwxr-xr-xgit-p4.py3
1 files changed, 2 insertions, 1 deletions
diff --git a/git-p4.py b/git-p4.py
index c8ae83d50..7efa9a862 100755
--- a/git-p4.py
+++ b/git-p4.py
@@ -571,7 +571,8 @@ def gitConfig(key, args = None): # set args to "--bool", for instance
def gitConfigList(key):
if not _gitConfig.has_key(key):
- _gitConfig[key] = read_pipe("git config --get-all %s" % key, ignore_error=True).strip().split(os.linesep)
+ s = read_pipe(["git", "config", "--get-all", key], ignore_error=True)
+ _gitConfig[key] = s.strip().split(os.linesep)
return _gitConfig[key]
def p4BranchesInGit(branchesAreInRemotes=True):