aboutsummaryrefslogtreecommitdiff
path: root/git-rebase.sh
diff options
context:
space:
mode:
authorShawn O. Pearce <spearce@spearce.org>2007-11-09 06:06:10 -0500
committerJunio C Hamano <gitster@pobox.com>2007-11-10 01:52:54 -0800
commit295dd2ad201c0ebb281563750a13d904bd466e01 (patch)
treee46bff288f44da5c22c05b94212c5225b0767187 /git-rebase.sh
parentb9217c09386e5313ac6a54cc91cf03149514154b (diff)
downloadgit-295dd2ad201c0ebb281563750a13d904bd466e01.tar.gz
git-295dd2ad201c0ebb281563750a13d904bd466e01.tar.xz
Fix memory leak in traverse_commit_list
If we were listing objects too then the objects were buffered in an array only reachable from a stack allocated structure. When this function returns that array would be leaked as nobody would have a reference to it anymore. Historically this hasn't been a problem as the primary user of traverse_commit_list() (the noble git-rev-list) would terminate as soon as the function was finished, thus allowing the operating system to cleanup memory. However we have been leaking this data in git-pack-objects ever since that program learned how to run the revision listing internally, rather than relying on reading object names from git-rev-list. To better facilitate reuse of traverse_commit_list during other builtin tools (such as git-fetch) we shouldn't leak temporary memory like this and instead we need to clean up properly after ourselves. Signed-off-by: Shawn O. Pearce <spearce@spearce.org> Signed-off-by: Junio C Hamano <gitster@pobox.com>
Diffstat (limited to 'git-rebase.sh')
0 files changed, 0 insertions, 0 deletions