aboutsummaryrefslogtreecommitdiff
path: root/gitweb
diff options
context:
space:
mode:
authorJakub Narebski <jnareb@gmail.com>2006-08-22 19:05:24 +0200
committerJunio C Hamano <junkio@cox.net>2006-08-22 16:12:26 -0700
commit1149fecfc270a2effc344897989f40afe449a72c (patch)
tree54f04463890dbaf3dbf776d0d3bde2353c74fa05 /gitweb
parent59b9f61a3f76762dc975e99cc05335a3b97ad1f9 (diff)
downloadgit-1149fecfc270a2effc344897989f40afe449a72c.tar.gz
git-1149fecfc270a2effc344897989f40afe449a72c.tar.xz
gitweb: Drop the href() params which keys are not in %mapping
If someone would enter parameter name incorrectly, and some key of %params is not found in %mapping hash, the parameter is now ignored. Change introduced by Martin Waitz in commit 756d2f064b2419fcdf9cd9c851f352e2a4f75103 tried to do that, but it left empty value and there was doubled ";;" in returned string. Signed-off-by: Jakub Narebski <jnareb@gmail.com> Signed-off-by: Junio C Hamano <junkio@cox.net>
Diffstat (limited to 'gitweb')
-rwxr-xr-xgitweb/gitweb.perl2
1 files changed, 1 insertions, 1 deletions
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 1c8a2ebe1..43b160048 100755
--- a/gitweb/gitweb.perl
+++ b/gitweb/gitweb.perl
@@ -285,7 +285,7 @@ sub href(%) {
my $href = "$my_uri?";
$href .= esc_param( join(";",
map {
- "$mapping{$_}=$params{$_}" if defined $params{$_}
+ defined $params{$_} ? "$mapping{$_}=$params{$_}" : ()
} keys %params
) );